openbsc[master]: bts: extend bts_chan_load to allow counting tch only

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Sep 25 14:57:29 UTC 2016


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/793/2/openbsc/src/libbsc/chan_alloc.c
File openbsc/src/libbsc/chan_alloc.c:

Line 523: 		case GSM_PCHAN_TCH_F_PDCH:
This is actually wrong, GSM_PCHAN_TCH_F_PDCH use ts->flags, not ts->dyn below (due to historical reasons and could be unified).

This is already committed, and I'm also touching this code today; so don't worry, I will send a patch that fixes this.


Line 560: 			if (only_count_tch && !chan_is_tch(ts))
This has exactly one effect: it excludes GSM_PCHAN_TCH_F_PDCH when in PDCH mode, because for all other PDCH (plain PDCH and TCH/F_TCH/H_PDCH in PDCH mode) below ts_subslots() returns 0 and skips the for() loop. I consider this a bug in TCH/F_PDCH (which I coincidentally found and then saw this patch; am fixing things now).

The point is, I don't see why we need the only_count_tch argument, because this should normally only count TCH, weren't it for the TCH/F_PDCH bug.

If dyn TS should be counted differently, we should do this in a different way.

My apologies, but all in all I would actually like to revert this commit.
Also apologies for not seeing this sooner, it's been sitting here for quite a while now.


-- 
To view, visit https://gerrit.osmocom.org/793
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86f1d502649747b6b9aefcb39081b14110e8f494
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list