[MERGED] osmo-bts[master]: lc15, sysmo: Use SID_FIRST_P1 to initiate DTX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Sep 23 15:16:16 UTC 2016


Max has submitted this change and it was merged.

Change subject: lc15, sysmo: Use SID_FIRST_P1 to initiate DTX
......................................................................


lc15, sysmo: Use SID_FIRST_P1 to initiate DTX

Some phone seems to not send SID_FIRST_P2 message which seems like a
different understanding of the DTX spec. L1 accommodates for that by
using P1 to supply data for SID. Hence we should use it to initiate DTX
and ignore P2 message in case of AMR HR.

Change-Id: Iaf993b89caa0ad49b97d1c745dcaf039f867f018
---
M src/osmo-bts-litecell15/tch.c
M src/osmo-bts-sysmo/tch.c
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-litecell15/tch.c b/src/osmo-bts-litecell15/tch.c
index 6ac2763..3c6ee25 100644
--- a/src/osmo-bts-litecell15/tch.c
+++ b/src/osmo-bts-litecell15/tch.c
@@ -445,8 +445,7 @@
 	case GsmL1_TchPlType_Amr:
 		rmsg = l1_to_rtppayload_amr(payload, payload_len, lchan);
 		break;
-	case GsmL1_TchPlType_Amr_SidFirstP2:
-		/* L1 do not give us SID_FIRST data, just indication */
+	case GsmL1_TchPlType_Amr_SidFirstP1:
 		memcpy(sid_first, payload, payload_len);
 		int len = osmo_amr_rtp_enc(sid_first, 0, AMR_SID, AMR_GOOD);
 		if (len < 0)
diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c
index 4ea95c5..745923c 100644
--- a/src/osmo-bts-sysmo/tch.c
+++ b/src/osmo-bts-sysmo/tch.c
@@ -548,8 +548,7 @@
 	case GsmL1_TchPlType_Amr:
 		rmsg = l1_to_rtppayload_amr(payload, payload_len, lchan);
 		break;
-	case GsmL1_TchPlType_Amr_SidFirstP2:
-		/* L1 do not give us SID_FIRST data, just indication */
+	case GsmL1_TchPlType_Amr_SidFirstP1:
 		memcpy(sid_first, payload, payload_len);
 		int len = osmo_amr_rtp_enc(sid_first, 0, AMR_SID, AMR_GOOD);
 		if (len < 0)

-- 
To view, visit https://gerrit.osmocom.org/692
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf993b89caa0ad49b97d1c745dcaf039f867f018
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list