[MERGED] libosmocore[master]: log telnet bind address and port

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: log telnet bind address and port
......................................................................


log telnet bind address and port

Log 'telnet at 1.2.3.4 5678' from telnet_init*. All callers can now drop any
extra 'VTY at 1.2.3.4 5678' logging.

Change-Id: I1da7b9076311d9458caea732fc0daace6533a3fd
---
M src/vty/telnet_interface.c
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c
index 50b08c8..e86a6b1 100644
--- a/src/vty/telnet_interface.c
+++ b/src/vty/telnet_interface.c
@@ -86,7 +86,14 @@
 
 	server_socket.data = priv;
 
-	return (rc < 0) ? -1 : 0;
+	if (rc < 0) {
+		LOGP(DLGLOBAL, LOGL_ERROR, "Cannot bind telnet at %s %d\n",
+		     ip, port);
+		return -1;
+	}
+
+	LOGP(DLGLOBAL, LOGL_NOTICE, "telnet at %s %d\n", ip, port);
+	return 0;
 }
 
 extern struct host host;

-- 
To view, visit https://gerrit.osmocom.org/891
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1da7b9076311d9458caea732fc0daace6533a3fd
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder