[MERGED] libosmocore[master]: log CTRL bind address and port

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 23 02:39:13 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: log CTRL bind address and port
......................................................................


log CTRL bind address and port

Log 'CTRL at 1.2.3.4 5678' from ctrl_interface_setup*. All callers can now drop
any extra 'CTRL at 1.2.3.4 5678' logging.

Change-Id: If449d0514e3d0cc1b346d7452194d931aa090166
---
M src/ctrl/control_if.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c
index 05f6c76..2ffc251 100644
--- a/src/ctrl/control_if.c
+++ b/src/ctrl/control_if.c
@@ -669,11 +669,14 @@
 	if (ret)
 		goto err_vec;
 
+	LOGP(DLCTRL, LOGL_NOTICE, "CTRL at %s %u\n", bind_addr, port);
 	return ctrl;
 err_vec:
 	vector_free(ctrl_node_vec);
 	ctrl_node_vec = NULL;
 err:
+	LOGP(DLCTRL, LOGL_ERROR, "Cannot bind CTRL at %s %u\n",
+	     bind_addr, port);
 	talloc_free(ctrl);
 	return NULL;
 }

-- 
To view, visit https://gerrit.osmocom.org/892
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If449d0514e3d0cc1b346d7452194d931aa090166
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list