openbsc[master]: SNDCP: add RFC1144 header compression functionality

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 23 02:34:20 UTC 2016


Patch Set 31:

(1 comment)

please check if you introduce other talloc from NULL context, and if so, fix all of them.  If there's a different talloc object from whihc we can allocate the new data, use that.  If not, introduce a new context off our tall_bsc_ctx or so, something like a tall_pcomp_ctx, which is then used for all allocations related to compression.

https://gerrit.osmocom.org/#/c/642/31/openbsc/src/gprs/gprs_sndcp_pcomp.c
File openbsc/src/gprs/gprs_sndcp_pcomp.c:

Line 106: 	data_o = talloc_zero_size(NULL, len);
please never use the NULl talloc context.  Always use a meaningful context so we can keep track of the allocatiosn.


-- 
To view, visit https://gerrit.osmocom.org/642
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia00260dc09978844c2865957b4d43000b78b5e43
Gerrit-PatchSet: 31
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list