[MERGED] libosmocore[master]: timer_test: remove unused precision values and confusing log

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 23 02:18:16 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: timer_test: remove unused precision values and confusing log
......................................................................


timer_test: remove unused precision values and confusing log

Change-Id: I1570b7096c757d63d23e0950feeeb7230f8a5c9f
---
M tests/timer/timer_test.c
M tests/timer/timer_test.ok
2 files changed, 2 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c
index c576a04..1aeab45 100644
--- a/tests/timer/timer_test.c
+++ b/tests/timer/timer_test.c
@@ -59,10 +59,6 @@
 /* time between two steps, in secs. */
 #define TIME_BETWEEN_STEPS	1
 
-/* timer imprecision that we accept for this test: 10 milliseconds. */
-#define TIMER_PRES_SECS		0
-#define TIMER_PRES_USECS	20000
-
 static int timer_nsteps = MAIN_TIMER_NSTEPS;
 static unsigned int expired_timers = 0;
 static unsigned int total_timers = 0;
@@ -185,9 +181,7 @@
 		}
 	}
 
-	fprintf(stdout, "Running timer test for %u steps, accepting "
-		"imprecision of %u.%.6u seconds\n",
-		timer_nsteps, TIMER_PRES_SECS, TIMER_PRES_USECS);
+	fprintf(stdout, "Running timer test for %u steps\n", timer_nsteps);
 
 	osmo_timer_schedule(&main_timer, 1, 0);
 
diff --git a/tests/timer/timer_test.ok b/tests/timer/timer_test.ok
index 7c00000..22b93aa 100644
--- a/tests/timer/timer_test.ok
+++ b/tests/timer/timer_test.ok
@@ -1,2 +1,2 @@
-Running timer test for 5 steps, accepting imprecision of 0.020000 seconds
+Running timer test for 5 steps
 test over: added=31 expired=31 too_soon=0 too_late=0

-- 
To view, visit https://gerrit.osmocom.org/884
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1570b7096c757d63d23e0950feeeb7230f8a5c9f
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list