osmo-bts[master]: rsl: improved log output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 23 02:11:28 UTC 2016


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/902/1/src/common/rsl.c
File src/common/rsl.c:

Line 1436: 	/* locally bound IP */
this changes the order of IEs in the RSL message, whcih I don't think is a good idea. The rlated change should be reverted, or split into a separate patch


Line 1589: 		LOGP(DRSL, LOGL_NOTICE, "connect_ip %d \n", connect_ip );
these logging related changes are fine with me. but not the IE re-ordering above.


-- 
To view, visit https://gerrit.osmocom.org/902
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaa253e5baed5ca364dfbc046a7cb559f106bfbd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list