[PATCH] libosmocore[master]: osmo_select_main(): drop useless call to osmo_timers_check()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Sep 22 04:10:31 UTC 2016


Review at  https://gerrit.osmocom.org/872

osmo_select_main(): drop useless call to osmo_timers_check()

osmo_timers_check() does nothing more than counting the active timers. It is of
no use to count them when not using the return value in any way.

Change-Id: I8d35ca90a4c16d6f1c7f9793d663e5479783efed
---
M src/select.c
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/872/1

diff --git a/src/select.c b/src/select.c
index 192cae2..da27368 100644
--- a/src/select.c
+++ b/src/select.c
@@ -176,8 +176,6 @@
 	/* prepare read and write fdsets */
 	osmo_fd_fill_fds(&readset, &writeset, &exceptset);
 
-	osmo_timers_check();
-
 	if (!polling)
 		osmo_timers_prepare();
 	rc = select(maxfd+1, &readset, &writeset, &exceptset, polling ? &no_time : osmo_timers_nearest());

-- 
To view, visit https://gerrit.osmocom.org/872
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d35ca90a4c16d6f1c7f9793d663e5479783efed
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list