libosmocore[master]: Fix ASAN failure in bitrev_test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Sep 21 16:12:45 UTC 2016


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/863/1/tests/bits/bitrev_test.c
File tests/bits/bitrev_test.c:

Line 296: 	for (offs = 0; offs < 12; offs++) {
Actually, only the last sh_chk should be omitted for offs == 12,
the other three should still run. I have an alternative patch,
will submit it shortly.

Details: 'offs' should rather be called 'number_of_nibbles',
and it goes up to 12 (< 13). in2 has exactly 12 nibbles.
But to shift left, there needs to be one more nibble (i.e. byte) of data.
So in2 has too few nibbles to shift left 12 nibbles.
The other three cases have sufficient data to run with 12.


-- 
To view, visit https://gerrit.osmocom.org/863
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5eb3f600290c05b4ab9ac2450a28d616e6b415fd
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list