[PATCH] libosmo-abis[master]: Use callback for polling data

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Sep 20 17:22:06 UTC 2016


Review at  https://gerrit.osmocom.org/864

Use callback for polling data

Previously rs->rtp_bfd.when and rs->rtcp_bfd.when value of BSC_FD_READ
was overridden by 0. Fix it.

Reported by coverity: CID 1357763.

Change-Id: I11940cbf50361c4ea262d7001a16f9a982392f27
---
M src/trau/osmo_ortp.c
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/64/864/1

diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c
index cc1d748..0bb1197 100644
--- a/src/trau/osmo_ortp.c
+++ b/src/trau/osmo_ortp.c
@@ -218,7 +218,6 @@
 	rs->rtp_bfd.fd = rtp_session_get_rtp_socket(rs->sess);
 	rs->rtcp_bfd.fd = rtp_session_get_rtcp_socket(rs->sess);
 	rs->rtp_bfd.when = rs->rtcp_bfd.when = BSC_FD_READ;
-	rs->rtp_bfd.when = rs->rtcp_bfd.when = 0;
 	rs->rtp_bfd.data = rs->rtcp_bfd.data = rs;
 	rs->rtp_bfd.cb = osmo_rtp_fd_cb;
 	rs->rtcp_bfd.cb = osmo_rtcp_fd_cb;

-- 
To view, visit https://gerrit.osmocom.org/864
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11940cbf50361c4ea262d7001a16f9a982392f27
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list