[MERGED] openbsc[master]: log: abis_rsl: don't log 'error' when there is no error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Sep 17 09:58:54 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: log: abis_rsl: don't log 'error' when there is no error
......................................................................


log: abis_rsl: don't log 'error' when there is no error

The message 'RF Channel Release due error 0' keeps catching my eye because
it says 'error' even though the error code is zero, i.e. no error.
This shall end now.

Change-Id: Ie0b9d62e8ce85a096c963931e0ae5527b8dc490a
---
M openbsc/src/libbsc/abis_rsl.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index 4c8448e..d3d9f9e 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -803,7 +803,11 @@
 	msg->lchan = lchan;
 	msg->dst = lchan->ts->trx->rsl_link;
 
-	DEBUGP(DRSL, "%s RF Channel Release CMD due error %d\n", gsm_lchan_name(lchan), error);
+	if (error)
+		DEBUGP(DRSL, "%s RF Channel Release due to error: %d\n",
+		       gsm_lchan_name(lchan), error);
+	else
+		DEBUGP(DRSL, "%s RF Channel Release\n", gsm_lchan_name(lchan));
 
 	if (error) {
 		/*

-- 
To view, visit https://gerrit.osmocom.org/749
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0b9d62e8ce85a096c963931e0ae5527b8dc490a
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list