[MERGED] osmo-bts[master]: log: sysmo, lc15: tweak log about sapi_cmds queue

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: log: sysmo,lc15: tweak log about sapi_cmds queue
......................................................................


log: sysmo,lc15: tweak log about sapi_cmds queue

The osmo-bts log used to say this a lot:

DL1C <0006> oml.c:758 (bts=0,trx=0,ts=0,ss=1) End of queue encountered. Now empty? 1

- Move this to DEBUG level instead of NOTICE.

- Tweak wording and logic so it says one of:
  [...] End of SAPI cmd queue encountered. Queue is now empty.
  [...] End of SAPI cmd queue encountered. More pending.

Change-Id: I5a46c90d016cee9b50f32db2af568765d3cb74cc
---
M src/osmo-bts-litecell15/oml.c
M src/osmo-bts-sysmo/oml.c
2 files changed, 12 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-litecell15/oml.c b/src/osmo-bts-litecell15/oml.c
index a175af4..634c236 100644
--- a/src/osmo-bts-litecell15/oml.c
+++ b/src/osmo-bts-litecell15/oml.c
@@ -755,9 +755,12 @@
 	talloc_free(cmd);
 
 	if (end || llist_empty(&lchan->sapi_cmds)) {
-		LOGP(DL1C, LOGL_NOTICE,
-			"%s End of queue encountered. Now empty? %d\n",
-			gsm_lchan_name(lchan), llist_empty(&lchan->sapi_cmds));
+		LOGP(DL1C, LOGL_DEBUG,
+			"%s End of SAPI cmd queue encountered.%s\n",
+			gsm_lchan_name(lchan),
+			llist_empty(&lchan->sapi_cmds)
+				? " Queue is now empty."
+				: " More pending.");
 		return;
 	}
 
diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c
index dea1c5e..c1f1e0b 100644
--- a/src/osmo-bts-sysmo/oml.c
+++ b/src/osmo-bts-sysmo/oml.c
@@ -764,9 +764,12 @@
 	talloc_free(cmd);
 
 	if (end || llist_empty(&lchan->sapi_cmds)) {
-		LOGP(DL1C, LOGL_NOTICE,
-			"%s End of queue encountered. Now empty? %d\n",
-			gsm_lchan_name(lchan), llist_empty(&lchan->sapi_cmds));
+		LOGP(DL1C, LOGL_DEBUG,
+			"%s End of SAPI cmd queue encountered.%s\n",
+			gsm_lchan_name(lchan),
+			llist_empty(&lchan->sapi_cmds)
+				? " Queue is now empty."
+				: " More pending.");
 		return;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/755
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a46c90d016cee9b50f32db2af568765d3cb74cc
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder