This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/819/3/src/bts.h File src/bts.h: Line 199: enum maximise_direction max_ts_direction_cfgd; I read the name as "maximum timeslot direction configured", a bit confusing. How about maximise_direction like the enum, or maximise_dir? Check whether an enum in this struct is ok. Is the struct used only internally in osmo-pcu? I'm not entirely sure that I know the main reasons, but sometimes we prefer an int. (When you were using a uint8_t in a previous version I assumed it was to avoid an enum for ABI / encoding reasons.) https://gerrit.osmocom.org/#/c/819/3/src/gprs_rlcmac_ts_alloc.cpp File src/gprs_rlcmac_ts_alloc.cpp: Line 778: if (bts->max_ts_direction_cfgd == UL_ONLY) { switch() ? https://gerrit.osmocom.org/#/c/819/3/src/pcu_vty.c File src/pcu_vty.c: Line 512: bts->max_ts_direction_cfgd = UL_ONLY; I see you've removed the final else, but I think there should be a way to switch it back to the default. Maybe a 'no maximise-direction' could make sense, or 'maximise-direction none'? -- To view, visit https://gerrit.osmocom.org/819 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b4a99194ccae68bb3417bce538d16e944d5ec71 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes