openbsc[master]: Sanity fixes for gsm0408_dispatch(): rc, assertions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Sep 17 02:26:38 UTC 2016


Patch Set 1:

I wasn't thinking that far. Fixed the coverity issue and saw that
two failure paths returned rc = 0.

There are several callers of gsm0408_dispatch(), none of which
actually care about the rc.

IuCS will add a caller that takes the rc all the way back to the
IuCS rx callback ... and then ignores it.

I guess letting the MS/UE know about failures like these is a whole
new thing to get involved in, so I'd "postpone" it:
https://osmocom.org/issues/1812

-- 
To view, visit https://gerrit.osmocom.org/855
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec39c74a53ef4dfa971dd935c8c9aa60fef58c1
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list