This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 2: Code-Review-1
(2 comments)
please use more conscise wording to avoid misunderstandings.
https://gerrit.osmocom.org/#/c/795/1/openbsc/include/openbsc/gsm_data.h
File openbsc/include/openbsc/gsm_data.h:
Line 235: "base station controller",
please use "[count] total amount of calls that ever reached active state" to make it clear that it is not about the currently concurrently active calls.
https://gerrit.osmocom.org/#/c/795/2/openbsc/include/openbsc/gsm_data.h
File openbsc/include/openbsc/gsm_data.h:
Line 227: [MSC_CTR_CALL_ACTIVE] = {"call.active", "Count amount of calls reached state active."},
please use "[count] total amount of calls that ever reached active state" to make it clear that it is not about the currently concurrently active calls.
--
To view, visit https://gerrit.osmocom.org/795
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49b93af2e6a0ba16c2fb00b7b83974e8a6a16df3
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes