osmo-pcu[master]: EGPRS: Fix issue with row 4 of Table 10.4.14a.1 of 44.060 ve...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Thu Sep 15 11:07:42 UTC 2016


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/826/2/src/decoding.cpp
File src/decoding.cpp:

Line 77: 			chunks[num_chunks].is_complete = true;
> I know what the spec says, which I quoted in my question. Quoting the same
Hi neels,

What i meant was, When we receive this condition. That means there was a pdu which ended in last block but there was no LI to indicate it. so the old PDU is still pending in the buffer. when this block received, we have to conclude the same and send the old PDU towards SGSN. and New LLC PDU starts with this block and it may end or continue in next block. 

So we have to set 1 chunk(index 0) with complete as true and length as 0. and next chunk details will be concluded below.


Thanks,
Aravind Sirsikar


-- 
To view, visit https://gerrit.osmocom.org/826
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cd0fca3ed28a553ede3f4b8a7d3267284dd2c9b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list