osmo-pcu[master]: EGPRS: Adds support of row 4 of Table 10.4.14a.1 of 44.060

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Thu Sep 15 06:40:11 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/826/1/src/decoding.cpp
File src/decoding.cpp:

Line 77: 			chunks[num_chunks].is_complete = true;
> Are you sure is_complete shall always be true here?
spec says as below==> /* TS 44.060, table 10.4.14a.1, row 4 */

1st LI: value=0  1 

The previous RLC data block contains a Upper Layer PDU, or a part of it, that fills precisely the previous data block and for which there is no length indicator in that RLC data block. The current RLC data block contains a Upper Layer PDU that either fills the current RLC data block precisely or continues in the next RLC data blcok.


-- 
To view, visit https://gerrit.osmocom.org/826
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cd0fca3ed28a553ede3f4b8a7d3267284dd2c9b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list