osmo-pcu[master]: tbf_dl: factor out EGPRS DL window size calculation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Wed Sep 14 13:11:48 UTC 2016


Patch Set 6:

(3 comments)

https://gerrit.osmocom.org/#/c/832/4/src/tbf.h
File src/tbf.h:

Line 375: 	void egprs_calc_window_size();
> obsolete comment. Any comment that is 1:1 the function name should rather b
Done


Line 376: 
> usually the naming should be ordered
Done


https://gerrit.osmocom.org/#/c/832/4/src/tbf_dl.cpp
File src/tbf_dl.cpp:

Line 1328: 	struct gprs_rlcmac_bts *bts_data = bts->bts_data();
> obsolete comment
Done


-- 
To view, visit https://gerrit.osmocom.org/832
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c7777d43f843bbd3421503fc2a8600f148ca035
Gerrit-PatchSet: 6
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list