This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 8:
(3 comments)
minor details, sorry to not have spotted earlier
https://gerrit.osmocom.org/#/c/430/8/src/bts.cpp
File src/bts.cpp:
Line 520: /* set class to 0,as we don't know the multislot
(not really necessary to modify the comment like this and introduce a whitespace error at the same time)
Line 591: ((burst_type == GSM_L1_BURST_TYPE_ACCESS_1) ||
here you indent once within the if ( ) condition,
below you indent twice. Please check what style is used
in the surrounding code and stick to that.
Line 616: (burst_type == GSM_L1_BURST_TYPE_ACCESS_0)) {
(two indents here, only one above)
--
To view, visit https://gerrit.osmocom.org/430
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d74a32f7764644ed86f7fdf97fa3c2f61503f7
Gerrit-PatchSet: 8
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes