This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: (3 comments) Still found some cosmetic details, sorry for not spotting them earlier... https://gerrit.osmocom.org/#/c/832/4/src/tbf.h File src/tbf.h: Line 375: /* EGPRS: window size calculation function */ obsolete comment. Any comment that is 1:1 the function name should rather be omitted. Line 376: void calc_egprs_window_size(); usually the naming should be ordered <subject>_<action> so I'd put 'egprs_' in front. https://gerrit.osmocom.org/#/c/832/4/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 1328: * for EGPRS. obsolete comment -- To view, visit https://gerrit.osmocom.org/832 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c7777d43f843bbd3421503fc2a8600f148ca035 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes