[PATCH] libosmocore[master]: comment: */ports.h: link to wiki + manuals, indicate used ports

[Neels Hofmeyr]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/833

to look at the new patch set (#2).

comment: */ports.h: link to wiki + manuals, indicate used ports

Change-Id: I6a7bf04e589ccfaea98f20900a9bfe9dd4808dce
---
M include/osmocom/ctrl/ports.h
M include/osmocom/vty/ports.h
2 files changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/833/2

diff --git a/include/osmocom/ctrl/ports.h b/include/osmocom/ctrl/ports.h
index c89bbe3..9642193 100644
--- a/include/osmocom/ctrl/ports.h
+++ b/include/osmocom/ctrl/ports.h
@@ -1,10 +1,18 @@
 #pragma once
 
-/* TCP port numbers used for CTRL interfaces in osmocom projects */
+/*
+ * TCP port numbers used for CTRL interfaces in osmocom projects. See also the
+ * osmocom wiki as well as the osmo-gsm-manuals, which should all be kept in
+ * sync with this file:
+ * https://osmocom.org/projects/cellular-infrastructure/wiki/PortNumbers
+ * https://git.osmocom.org/osmo-gsm-manuals/tree/common/chapters/port_numbers.adoc
+ */
 
 #define OSMO_CTRL_PORT_BTS	4238
 #define OSMO_CTRL_PORT_NITB_BSC	4249
 #define OSMO_CTRL_PORT_BSC_NAT	4250
 #define OSMO_CTRL_PORT_SGSN	4251
 #define OSMO_CTRL_PORT_GGSN	4252
+/* 4252-4254 used by VTY interface */
 #define OSMO_CTRL_PORT_CSCN	4255
+/* 4256 used by VTY interface */
diff --git a/include/osmocom/vty/ports.h b/include/osmocom/vty/ports.h
index 75b8044..b135515 100644
--- a/include/osmocom/vty/ports.h
+++ b/include/osmocom/vty/ports.h
@@ -1,6 +1,12 @@
 #pragma once
 
-/* TCP port numbers used for VTY interfaces in osmocom projects */
+/*
+ * TCP port numbers used for VTY interfaces in osmocom projects. See also the
+ * osmocom wiki as well as the osmo-gsm-manuals, which should all be kept in
+ * sync with this file:
+ * https://osmocom.org/projects/cellular-infrastructure/wiki/PortNumbers
+ * https://git.osmocom.org/osmo-gsm-manuals/tree/common/chapters/port_numbers.adoc
+ */
 
 /* 4238 used by osmo-bts control interface */
 #define OSMO_VTY_PORT_PCU	4240	/* also: osmo_pcap_client */

-- 
To view, visit https://gerrit.osmocom.org/833
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a7bf04e589ccfaea98f20900a9bfe9dd4808dce
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder