libosmocore[master]: utils/conv_gen.py: add EDGE MCS 1-9 definitions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Sep 9 10:16:50 UTC 2016


Patch Set 1:

> the question to me is, both regarding the existing GSM coding
 > schemes and the new EGPRS MCS: Where are the test cases?
 > 
 > We should be able to do a pretty simple Encode -> Decode test to
 > test against our own encoder, and have that test be executed with
 > every of the convolutional codes.  We should also be able to
 > introduce a defined amount of bit errors and check if the decoder
 > can still recover as expected (won't work for MCS-9/CS-4, of
 > course).
 > 
 > We should also test decoding of some hardcoded 'const uint8_t'
 > arrays of actual messages produced by a different encoder (e.g from
 > air interface traces).

 > the question to me is, both regarding the existing GSM coding
 > schemes and the new EGPRS MCS: Where are the test cases?
 > 
 > We should be able to do a pretty simple Encode -> Decode test to
 > test against our own encoder, and have that test be executed with
 > every of the convolutional codes.  We should also be able to
 > introduce a defined amount of bit errors and check if the decoder
 > can still recover as expected (won't work for MCS-9/CS-4, of
 > course).
 > 
 > We should also test decoding of some hardcoded 'const uint8_t'
 > arrays of actual messages produced by a different encoder (e.g from
 > air interface traces).

I am absolutely agree with you, but right now I have no
opportunity to write corresponding tests. Also, I have no
corresponding air interface traces at this moment. But I
will try to solve this problem.

Can we add tests in a separate commit?

-- 
To view, visit https://gerrit.osmocom.org/837
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1452342f524a8b60f2babc07398a1d9c9e06aa3
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list