[MERGED] libosmocore[master]: libosmocodec link fix on MacOSX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 9 06:35:21 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: libosmocodec link fix on MacOSX
......................................................................


libosmocodec link fix on MacOSX

Fixes the following bug:

  CCLD     libosmocodec.la
Undefined symbols for architecture x86_64:
  "_bitvec_get_bit_pos", referenced from:
      _osmo_fr_check_sid in gsm610.o
  "_bitvec_get_uint", referenced from:
      _osmo_hr_check_sid in gsm620.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libosmocodec.la] Error 1

Change-Id: Id7358b94e274b529a8da38a0b2ef8c892b6dd7a5
---
M src/codec/Makefile.am
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/codec/Makefile.am b/src/codec/Makefile.am
index 619897f..5c69c28 100644
--- a/src/codec/Makefile.am
+++ b/src/codec/Makefile.am
@@ -9,3 +9,4 @@
 
 libosmocodec_la_SOURCES = gsm610.c gsm620.c gsm660.c gsm690.c
 libosmocodec_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined
+libosmocodec_la_LIBADD = $(top_builddir)/src/libosmocore.la

-- 
To view, visit https://gerrit.osmocom.org/802
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7358b94e274b529a8da38a0b2ef8c892b6dd7a5
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list