This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(8 comments)
https://gerrit.osmocom.org/#/c/824/1/openbsc/src/gprs/Makefile.am
File openbsc/src/gprs/Makefile.am:
Line 35: $(OSMO_LIBS) $(LIBCARES_LIBS) $(LIBCRYPTO_LIBS) -lrt
Here and below, it is rather complex to see what is a fix and what is cosmetic. Please put the cosmetic cleanups in a separate commit.
https://gerrit.osmocom.org/#/c/824/1/openbsc/src/libiu/Makefile.am
File openbsc/src/libiu/Makefile.am:
Line 12: $(COVERAGE_CFLAGS)
Again, rather don't mix cosmetics with functional changes
https://gerrit.osmocom.org/#/c/824/1/openbsc/tests/gtphub/Makefile.am
File openbsc/tests/gtphub/Makefile.am:
Line 2: AM_CFLAGS=-Wall -ggdb3 \
(the commit with cosmetic fixes could add spaces around the '=' here)
https://gerrit.osmocom.org/#/c/824/1/openbsc/tests/mm_auth/Makefile.am
File openbsc/tests/mm_auth/Makefile.am:
Line 2: AM_CFLAGS=-Wall \
(' = ')
https://gerrit.osmocom.org/#/c/824/1/openbsc/tests/sgsn/Makefile.am
File openbsc/tests/sgsn/Makefile.am:
Line 6: $(LIBCARES_CFLAGS) \
(separate commit)
Line 8:
since 'if BUILD_IU' adds more items to AM_CFLAGS, I guess
we should not add a blank line here
Line 42: $(top_builddir)/src/gprs/gprs_llc_xid.o \
another pre-existing whitespace error :)
(should be tab to indent)
Line 52:
again, still related to sgsn_test_*, so I'd not add a blank line
--
To view, visit https://gerrit.osmocom.org/824
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bd4f7a0b0bce0184f093ac61099c6681a458f65
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: ahuemer <alexander.huemer at xx.vu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes