This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/551/4/openbsc/include/openbsc/gsm_data.h
File openbsc/include/openbsc/gsm_data.h:
Line 220: [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms.deliver_unknown_error", "While trying to deliver an unknown error attempted."},
attempted? should be 'occured', right?
Nitpicking: the other messages use this order of words:
'Unknown error during sms delivery attempt'
(though I'd have some fixed for those, too)
--
To view, visit https://gerrit.osmocom.org/551
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia03e50ce2bd9a7d1054cc5a6000fd73bd3497c03
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes