This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(4 comments)
https://gerrit.osmocom.org/#/c/811/1//COMMIT_MSG
Commit Message:
Line 7: LC15: Implementation of TS 12.21 measurement related messages to measure PCU KPI
the commit message should contain much more details on this. First of all, it seems that the specific measurement related messages are not part of TS 12.21, but rather related to the IPA dialect of OML. Secondly, please give a short summary of the measurement message types and how they are used.
https://gerrit.osmocom.org/#/c/811/1/include/osmo-bts/oml.h
File include/osmo-bts/oml.h:
Line 61: enum abis_nm_ipacc_meas_type {
if this is a definition about parts of the IPA-stype abis/ip, the related definitions belong into libosmogsm, from where they can be shared by both BTS and BSC (or other code).
https://gerrit.osmocom.org/#/c/811/1/src/common/oml.c
File src/common/oml.c:
Line 98: [NM_ATT_MEAS_TYPE] = { TLV_TYPE_TV },
when adding new definitions to an existing table or enum, pleas always use the same indenting as the existing elements.
Line 1214: LOGP(DOML, LOGL_NOTICE, "%s Unsupported NM STOP MEASurement type received 0x%02x\n", gsm_abis_mo_name(mo), meas_id);
please respect the 80-char-long-line limit of the kernel coding style that we use in osmocom.
--
To view, visit https://gerrit.osmocom.org/811
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I352600f964e6c161b9259c62f2e0a0f39f0f60d9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes