This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(4 comments)
https://gerrit.osmocom.org/#/c/809/1/include/osmo-bts/oml.h
File include/osmo-bts/oml.h:
Line 50: NM_EVT_CAUSE_CRIT_SW_FATAL = 0x3000,
who defined those cause value? are they from TS 12.21? If yes, the definitions should definitely go into libosmgsm abis_nm.h. If the'yre custom definitions, we need to mention it clearly here, and if possible also introduce a OSMO in the definition to make it explicit those cause values are not standard cause values. Like NM_EVT_CAUSE_OMSO_...
https://gerrit.osmocom.org/#/c/809/1/src/common/bts.c
File src/common/bts.c:
Line 180: INIT_LLIST_HEAD(&btsb->lc15.ceased_alarm_list);
is the 'ceased alarm' mechanism really Litecell 1.5 specific, or is it a more general feature that is shared among all BTS models?
https://gerrit.osmocom.org/#/c/809/1/src/common/rsl.c
File src/common/rsl.c:
Line 397: /* Send Failure event report of BTS page table is full to BSC */
we typically don't indent the 'case' below a 'switch'
https://gerrit.osmocom.org/#/c/809/1/src/osmo-bts-litecell15/calib_file.c
File src/osmo-bts-litecell15/calib_file.c:
Line 156: if( fl1h->phy_inst->trx ){
space missing, also in several other places.
--
To view, visit https://gerrit.osmocom.org/809
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e088a3af115d3d5a124b61c1e92eed277d3469
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes