This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/808/1/include/osmo-bts/gsm_data.h File include/osmo-bts/gsm_data.h: Line 115: /* specific to LC15 BTS */ we don't generally have bts-model specific state here for other BTSs. So if there's a more elegant method, let's explore that. I guess it is not possible to attach the state to the phy_link or phy_interface, as you have two phy_links and only one LED state control? https://gerrit.osmocom.org/#/c/808/1/src/osmo-bts-litecell15/l1_if.c File src/osmo-bts-litecell15/l1_if.c: Line 1243: if(btsb->lc15.led_ctrl_mode == LC15_LED_CONTROL_BTS) if is not a function call, hence we use space after 'if'. Line 1563: struct msgb *msg = sysp_msgb_alloc(); we typically declare all variables on top of the function. Sae below with 'int rc' and 'Litecell15_Prim_t'. https://gerrit.osmocom.org/#/c/808/1/src/osmo-bts-litecell15/lc15bts.h File src/osmo-bts-litecell15/lc15bts.h: Line 25: enum lc15_diversity_mode{ would be great to have a space here, like in the rest of the code. -- To view, visit https://gerrit.osmocom.org/808 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79416faaa3ba328c9c2dabcd695a1b880fe666da Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes