This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(5 comments)
looks ok in general, but fix minor issues please
https://gerrit.osmocom.org/#/c/812/1/include/osmocom/gsm/protocol/gsm_08_58.h
File include/osmocom/gsm/protocol/gsm_08_58.h:
Line 175: RSL_MT_IPAC_HO_CAN_RES = 0x62,
whitespace:
1x missing space '/* Exten...'
3x space-before-tab
typo: 'Extended'
Line 303: IPAC_UNWEIGHTED_AVE = 0,
All other names in this file start with RSL_.
I guess yours should thus be 'RSL_IPAC_*' or 'RSL_IE_IPAC_*'.
Line 335: };
add a blank line
Line 653: struct ipac_preproc_ave_cfg {
These structs will need a big-endian compat shim, see for example:
http://git.osmocom.org/libosmocore/plain/include/osmocom/gsm/protocol/gsm_03_41.h
struct gsm341_ms_message {
struct {
#if OSMO_IS_LITTLE_ENDIAN == 1
uint8_t code_hi:6;
uint8_t gs:2;
uint8_t update:4;
uint8_t code_lo:4;
#else
uint8_t gs:2;
uint8_t code_hi:6;
uint8_t code_lo:4;
uint8_t update:4;
#endif
(reverse the order within each 8-bit "frame")
https://gerrit.osmocom.org/#/c/812/1/src/gsm/rsl.c
File src/gsm/rsl.c:
Line 545: [RSL_IPAC_EIE_AMR_CONV_THRESH] = { TLV_TYPE_FIXED, 9 },
space before tab
--
To view, visit https://gerrit.osmocom.org/812
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1853697f4cff5ff98654fa1cae6c68e28a0076b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes