osmo-pcu[master]: Fix DL window calculation during tbf update

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Fri Sep 2 11:55:22 UTC 2016


Patch Set 1:

> Holger, is your comment ("business logic") saying the same thing as
 > mine? i.e. that the patch duplicates a calculation that should be
 > in

right. no code duplication!

 > So far I'm still expecting Arvind to un-duplicate.


me too

 > a separate function called from both places.
 > 
 > I'm afraid I don't follow on the latency/buffer bloat argument.
 
Technical details about EGPRS window size:

With EGPRS one can have a way bigger window (and select different sizes for UL and DL). While big windows are good for throughput it also means that _more_ data needs to be queued. The later is bad for latency and with "bufferbloat.org" the goal is to avoid queuing too much.

Empirically Jacob came to the conclusion to not use the maximum possible window size but to have it proportionate to the amount of PDCHs (in use).

-- 
To view, visit https://gerrit.osmocom.org/798
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41aa807068520460fd665a55e3529e60f6bbb630
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list