[PATCH] openbsc[master]: IuPS: RA UPD: make sure to authorize, for Iu Integrity Prote...

[Neels Hofmeyr]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/738

to look at the new patch set (#9).

IuPS: RA UPD: make sure to authorize, for Iu Integrity Protection

Change-Id: I2ea2089895f8a8e125ef39d9bef70dafb2b1ce69
---
M openbsc/src/gprs/gprs_gmm.c
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/38/738/9

diff --git a/openbsc/src/gprs/gprs_gmm.c b/openbsc/src/gprs/gprs_gmm.c
index b515abd..53b6322 100644
--- a/openbsc/src/gprs/gprs_gmm.c
+++ b/openbsc/src/gprs/gprs_gmm.c
@@ -50,6 +50,7 @@
 
 #ifdef BUILD_IU
 #include <osmocom/ranap/ranap_ies_defs.h>
+#include <osmocom/ranap/ranap_msg_factory.h>
 #endif
 
 #include <openbsc/debug.h>
@@ -853,9 +854,8 @@
 		ctx->pending_req = 0;
 		rc = gsm48_tx_gmm_service_ack(ctx);
 
-		if (ctx->iu.service.type == 1) {
+		if (ctx->iu.service.type != GPRS_SERVICE_T_SIGNALLING)
 			activate_pdp_rabs(ctx);
-		}
 
 		return rc;
 #endif
@@ -1540,8 +1540,11 @@
 		process_ms_ctx_status(mmctx, pdp_status);
 	}
 
-	/* Send RA UPDATE ACCEPT */
-	return gsm48_tx_gmm_ra_upd_ack(mmctx);
+	/* Send RA UPDATE ACCEPT. In Iu, the RA upd request can be called from
+	 * a new Iu connection, so we might need to re-authenticate the
+	 * connection as well as turn on integrity protection. */
+	mmctx->pending_req = GSM48_MT_GMM_RA_UPD_REQ;
+	return gsm48_gmm_authorize(mmctx);
 
 rejected:
 	/* Send RA UPDATE REJECT */

-- 
To view, visit https://gerrit.osmocom.org/738
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ea2089895f8a8e125ef39d9bef70dafb2b1ce69
Gerrit-PatchSet: 9
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>