osmo-pcu[master]: EGPRS: EPDAN decoding: add test case to show no ack_nack len...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Sep 2 01:12:23 UTC 2016


Patch Set 8: Code-Review-1

Also, please explain the test name and commit summary.
I see that this is about CSN1 decoding, and it seems that the "no
ack_nack len" is just one particular instance where this shows.

It seems a more accurate description would be:
"CSN1 CSN_LEFT_ALIGNED_VAR_BMP: add test case to show attempted decoding past vector end"

Would you agree, or is the case you describe as "no ack_nack len"
the only case where CSN_LEFT_ALIGNED_VAR_BMP hits?
I am not really familiar with CSN1 nor EPDAN -- so, do you have your facts straight?

-- 
To view, visit https://gerrit.osmocom.org/765
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8da84794748f2e81722c3eca69b46ccc3a21552e
Gerrit-PatchSet: 8
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list