This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
tnt gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/1173/2/utils/conv_gen.py File utils/conv_gen.py: Line 188: def gen_tables(self, pref, fi, shared_tables = False): Default to None and not 'False'. If you set a default to False, it kind of implies it's a boolean, which it is not. Then use 'shared_tables is None' or 'shared_tables is not None' to test. Line 973: shared = False Again 'False' vs 'None' -- To view, visit https://gerrit.osmocom.org/1173 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84760f5cdfdaece376b801d2e6cb2954ee875a3b Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-HasComments: Yes