This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-2 Ah, no, you picked the wrong dyn_ts function. The rsl_ipacc_ functions are marked ipacc for a reason: they are about the ip.access way of activating dynamic channels. The ip.access channels are only TCH/F_PDCH, and ip.access invented a non-standard RSL message to de/activate PDCH. Instead, you want the "fully dynamic" channel type which we called "Osmocom style dyn TS", which extends the RSL Chan Activ message to add a PDCH channel type to the cbits, as well as a PDCH specific Channel Activation Type IE value. It looks like you duplicated this extension which is already present. You want to use the TCH/F_TCH/H_PDCH pchan type, which was actually designed to follow the way Ericsson does dyn TS. See * GSM_PCHAN_TCH_F_TCH_H_PDCH * rsl_chan_activate_lchan() at "if (act_type == RSL_ACT_OSMO_PDCH) {" * rsl_chan_activate_lchan_as_pdch(), which should in fact compose a message compatible to Ericsson hardware. If this is not compatible to Ericsson, we should make it so, including any changes that might be necessary in osmo-bts. We should probably have talked about this beforehand. Sorry about that... The two different kinds of dyn TS are definitely confusing if you don't know about them, and an intro would have been helpful. -- To view, visit https://gerrit.osmocom.org/1155 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48089fcf8328d52f57e97b003790ffdeed766367 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: No