This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 7: Code-Review-1 (3 comments) Looks good. Please comment on why not storing to unsigned right away? https://gerrit.osmocom.org/#/c/862/7/src/rlc.cpp File src/rlc.cpp: Line 109: uint16_t dist = distance(); store to "unsigned" directly? Line 110: unsigned num_blocks = rbb->cur_bit > (unsigned)dist avoid the cast here? https://gerrit.osmocom.org/#/c/862/7/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 851: uint16_t distance = m_window.distance(); then store to unsigned int and stop cast? -- To view, visit https://gerrit.osmocom.org/862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 Gerrit-PatchSet: 7 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes