This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/862/6/src/rlc.h File src/rlc.h: Line 303: const uint16_t distance() const; No, rather not also do this within the same commit. distance() has existed before and if it needs a change in return value, that should be a separate commit on its own, with a separate review and possibly discussion. (It also necessitates checking all callers whether they need to be adjusted to avoid compiler warnings and remain type safe.) Such separate patch could go before or after this patch. If it comes before, the advantage is less casts in this patch, but it also means that this patch has to wait for the other one to be accepted. So I think personally I would make do with the signed return value for now, and *maybe* later on have another patch for the return value, removing type casts... -- To view, visit https://gerrit.osmocom.org/862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 Gerrit-PatchSet: 6 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes