osmo-bts[master]: Fix AGCH/PCH proportional allocation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Oct 18 18:54:18 UTC 2016


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/1099/1/src/osmo-bts-litecell15/oml.c
File src/osmo-bts-litecell15/oml.c:

Line 1026: 		lch_par->agch.u8NbrOfAgch = num_agch(lchan->ts->trx, "MPH.act");
lchan->name too?


https://gerrit.osmocom.org/#/c/1099/1/src/osmo-bts-octphy/l1_if.c
File src/osmo-bts-octphy/l1_if.c:

Line 490: 		/* FIXME: how does octphy differentiate between AGCH and PCH?
did you check the header? did you ask them? Runtime log message if config is not as will be used?


https://gerrit.osmocom.org/#/c/1099/1/src/osmo-bts-sysmo/oml.c
File src/osmo-bts-sysmo/oml.c:

Line 1041: 		lch_par->agch.u8NbrOfAgch = num_agch(lchan->ts->trx, lchan->name);
lc and bts should be similar but argument to num_agch is different?


-- 
To view, visit https://gerrit.osmocom.org/1099
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11377b12680ac3b2f77f80e742b6f0af63fc9c1e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list