[MERGED] libosmocore[master]: vty/show asciidoc: counters: improve table headers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Oct 18 13:33:36 UTC 2016


lynxis lazus has submitted this change and it was merged.

Change subject: vty/show asciidoc: counters: improve table headers
......................................................................


vty/show asciidoc: counters: improve table headers

add [options=header] to every table header
vty/show asciidoc: rename reference field into "Reference"
vty/show asciidoc: capilize table header field names

Change-Id: Ie991f4db77a60afb86a2a0b35c137586527f6228
---
M src/vty/stats_vty.c
1 file changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Holger Freyther: Looks good to me, approved



diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c
index 2ca436a..c03546b 100644
--- a/src/vty/stats_vty.c
+++ b/src/vty/stats_vty.c
@@ -383,8 +383,9 @@
 {
 	vty_out(vty, "// ungrouped osmo_counters%s", VTY_NEWLINE);
 	vty_out(vty, ".ungrouped osmo counters%s", VTY_NEWLINE);
+	vty_out(vty, "[options=\"header\"]%s", VTY_NEWLINE);
 	vty_out(vty, "|===%s", VTY_NEWLINE);
-	vty_out(vty, "| name | This document & | description%s", VTY_NEWLINE);
+	vty_out(vty, "| Name | Reference | Description%s", VTY_NEWLINE);
 	osmo_counters_for_each(asciidoc_handle_counter, vty);
 	vty_out(vty, "|===%s", VTY_NEWLINE);
 }
@@ -398,7 +399,7 @@
 	char *description = osmo_asciidoc_escape(desc->description);
 	char *group_name_prefix = osmo_asciidoc_escape(ctrg->desc->group_name_prefix);
 
-	/* | name | This document & | description | */
+	/* | Name | This document & | Description | */
 	vty_out(vty, "| %s | <<%s_%s>> | %s%s",
 		name,
 		group_name_prefix,
@@ -423,8 +424,9 @@
 
 	vty_out(vty, "// rate_ctr_group table %s%s", group_description, VTY_NEWLINE);
 	vty_out(vty, ".%s - %s %s", group_name_prefix, group_description, VTY_NEWLINE);
+	vty_out(vty, "[options=\"header\"]%s", VTY_NEWLINE);
 	vty_out(vty, "|===%s", VTY_NEWLINE);
-	vty_out(vty, "| name | This document & | description%s", VTY_NEWLINE);
+	vty_out(vty, "| Name | Reference | Description%s", VTY_NEWLINE);
 	rate_ctr_for_each_counter(ctrg, asciidoc_rate_ctr_handler, sctx_);
 	vty_out(vty, "|===%s", VTY_NEWLINE);
 
@@ -444,7 +446,7 @@
 	char *group_name_prefix = osmo_asciidoc_escape(statg->desc->group_name_prefix);
 	char *unit = osmo_asciidoc_escape(item->desc->unit);
 
-	/* | name | This document & | description | unit | */
+	/* | Name | Reference | Description | Unit | */
 	vty_out(vty, "| %s | <<%s_%s>> | %s | %s%s",
 		name,
 		group_name_prefix,
@@ -471,8 +473,9 @@
 
 	vty_out(vty, "// osmo_stat_item_group table %s%s", group_description ? group_description : "", VTY_NEWLINE);
 	vty_out(vty, ".%s - %s %s", group_name_prefix, group_description ? group_description : "", VTY_NEWLINE);
+	vty_out(vty, "[options=\"header\"]%s", VTY_NEWLINE);
 	vty_out(vty, "|===%s", VTY_NEWLINE);
-	vty_out(vty, "| name | This document & | description | unit%s", VTY_NEWLINE);
+	vty_out(vty, "| Name | Reference | Description | Unit%s", VTY_NEWLINE);
 	osmo_stat_item_for_each_item(statg, asciidoc_osmo_stat_item_handler, sctx_);
 	vty_out(vty, "|===%s", VTY_NEWLINE);
 

-- 
To view, visit https://gerrit.osmocom.org/1109
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie991f4db77a60afb86a2a0b35c137586527f6228
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>



More information about the gerrit-log mailing list