osmo-bts[master]: DTX AMR - fix buffer length check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Oct 16 22:02:14 UTC 2016


Patch Set 2:

> As length of RTP packet payload and L1-specific data is fixed, this
 > indeed not supposed to happen unless smth goes horribly wrong in
 > some other place.

Right now it looks like having too much data is a valid case. IMHO an OSMO_ASSERT or an error log would be more fitting than to carry on with a bad length. (An assertion only when the length depends entirely on osmo-bts, if it is based on incoming data the binary should not crash on this but error log instead.)

I'm still +ing this patch because it does fix the memory corruption in case too much data shows up. A follow-up would be nice.

-- 
To view, visit https://gerrit.osmocom.org/1064
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbc468caedf08f26893457db7c7fbacef5b860c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list