osmo-bts[master]: DTX AMR - fix buffer length check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Oct 14 12:24:24 UTC 2016


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/1064/2/src/common/msg_utils.c
File src/common/msg_utils.c:

Line 116: 				ARRAY_SIZE(lchan->tch.dtx.cache) - amr);
curiosity: what happens if less than length + 1 are written? Does data get lost? Is that supposed to never happen?


-- 
To view, visit https://gerrit.osmocom.org/1064
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbc468caedf08f26893457db7c7fbacef5b860c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list