This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 28: Code-Review+1 (1 comment) So you've chosen to go on for one more cycle ;) https://gerrit.osmocom.org/#/c/416/28/src/egprs_rlc_compression.cpp File src/egprs_rlc_compression.cpp: Line 297: * as described in section 9.1.10 of 3gpp 44.060. As before, please use the 80 characters width of space! Please check your sentences, here you end with a period in the middle of a sentence! '3GPP' in capital letters. It is a bit odd that I seem to write the changes as comments for you to apply them 1:1, but a nice fit including some indent would be * \param start[in] Starting Color Code, true if bitmap starts with a run * length of ones, false if zeros; see 9.1.10, 3GPP 44.060. -- To view, visit https://gerrit.osmocom.org/416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce Gerrit-PatchSet: 28 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: Yes