This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orgPatch Set 2: > New code can easily again use llc_queue()->size() by accident, > where C++ would technically have the tools in place to make > unwanted > access private. > > AFAICT all callers of llc_queue() are now private, right? > So we could make llc_queue() private altogether. The few private > callers > could then add an explicit null pointer check. > > (not to be confused with GprsMs::llc_queue()). I agree, but that would be another commit. -- To view, visit https://gerrit.osmocom.org/724 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88cc3180f8f86785e3f07981895dabddf50b60a2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-HasComments: No