This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 26: (9 comments) Looks like we're moving into the final cosmetics. I appreciate your patience with the review process. https://gerrit.osmocom.org/#/c/416/26/src/egprs_rlc_compression.cpp File src/egprs_rlc_compression.cpp: Line 24: } egprs_compress_node; since we're in C++ land, you don't need to have a name in the end. Think of 'struct' as exactly a 'class' that has public members. Line 30: struct egprs_compress_node *egprs_compress::create_tree_node(void *parent) since we're in C++, you don't need to repeat 'struct' here, only egprs_compress_node suffices. Line 32: struct egprs_compress_node *new_node; also no 'struct' necessary, same below numerous times. Line 45: return egprs_compress::s_instance; wrong indenting Line 81: * section 9.1.10 of 3gpp 44.060 */ very good, but put this comment above the 'if (idx < 64)' line Line 89: * of 3gpp 44.060 use 80 chars of width Line 280: >> (7 - (bit_pos & 0x07))) & 0x01; this actually fits on one 80 char wide line. Line 281: (bit_pos)++; drop the braces Line 297: * \param color_code_bit[in] Color code 1 for Ones runlength 0 for Zero runlength please still explain to me your choice of the term "color code". Is it a term used in the spec? I dimly remember this used in schools as a playful term for 'boolean'? If it's not a term from the spec I would probably name the param 'ones', so that true means Ones and false means Zeros. -- To view, visit https://gerrit.osmocom.org/416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce Gerrit-PatchSet: 26 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: Yes