osmo-pcu[master]: EGPRS: add test case to show EPDAN BSN out of window bug

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 13 01:01:06 UTC 2016


Patch Set 7: Code-Review+1

(2 comments)

I would appreciate the indicated comment change and a rebase onto master before submitting, but otherwise this looks good now.

https://gerrit.osmocom.org/#/c/861/6//COMMIT_MSG
Commit Message:

Line 9: This patch adds a test case test_tbf_epdan_out_of_rx_window,
> fix this
no need to generate noise by posting to yourself?


https://gerrit.osmocom.org/#/c/861/7/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

Line 2026:  * expects the same bug. which shall be fixed in subsequent patch
Shorten this to:

Test that a bit within the uncompressed bitmap whose BSN is not within the transmit window shall be ignored. See section 9.1.8.2.4 of 44.060 version 7.27.0 Release 7.


-- 
To view, visit https://gerrit.osmocom.org/861
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32b67f5c05707155281128b776a90a1e3d587b2
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list