osmo-bts[master]: octphy: Fixed OML ADM state handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 13 00:34:16 UTC 2016


Patch Set 9:

(3 comments)

https://gerrit.osmocom.org/#/c/906/9//COMMIT_MSG
Commit Message:

Line 7: octphy: Fixed OML ADM state handling
you mean, the state handling is fixed (=invariable), or this patch fixes it? :)
"fix OML ADM state handling"


Line 10: adds a proper state handling
but only for lock/unlock of OC_RADIO_CARRIER obj class. Basically all state handling is still accepted blindly, as the default cases don't error out.


https://gerrit.osmocom.org/#/c/906/9/src/osmo-bts-octphy/l1_oml.c
File src/osmo-bts-octphy/l1_oml.c:

Line 1579: 				     "TRX already closed..!\n\n");
when the user sees this log message, she has to guess what the code tried to do:
"Cannot close TRX, it is already closed."


-- 
To view, visit https://gerrit.osmocom.org/906
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I034114beca95210169429d8ac1eb8648df12fc6c
Gerrit-PatchSet: 9
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list