osmo-bts[master]: octphy: set tx attenuation via VTY

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 13 00:28:44 UTC 2016


Patch Set 10: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/905/10/src/osmo-bts-octphy/octphy_vty.c
File src/osmo-bts-octphy/octphy_vty.c:

Line 141: 	"oml or tx-attenuation in quarter-dB\n")
no, you would have one string for 'oml' and one for '<0-359>'.
I'd suggest:

OCT_STR "Set attenuation on transmitted RF\n"
"Use tx-attenuation according to OML instructions from BSC\n"
"Fixed tx-attenuation in quarter-dB\n")


-- 
To view, visit https://gerrit.osmocom.org/905
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76bb8660eb1d8baeb6b8f69da4a6ba9ab7319981
Gerrit-PatchSet: 10
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list