This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 2: Code-Review+2
(2 comments)
not sure what potential comp_...[] uint overflow Holger is talking about
https://gerrit.osmocom.org/#/c/965/2/openbsc/src/gprs/gprs_sndcp_xid.c
File openbsc/src/gprs/gprs_sndcp_xid.c:
Line 1373: lt[i].algo = comp_field->algo;
comp_field.algo is an int, but lt[i] aka entity_algo_table.algo is an unsigned int. That might be worth another look. But it's not part of this patch.
Line 1376: if (rc < 0) {
this fix is actually quite funny :)
--
To view, visit https://gerrit.osmocom.org/965
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9adf251f5119e67ffe76baad6f1f996ac8dbad
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: wax miguel <waxmigs2902 at gmail.com>
Gerrit-HasComments: Yes