This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 9: Code-Review-1
(4 comments)
https://gerrit.osmocom.org/#/c/905/9/include/osmo-bts/phy_link.h
File include/osmo-bts/phy_link.h:
Line 66: uint32_t tx_atten_flag;
we can make that a bool.
https://gerrit.osmocom.org/#/c/905/9/src/osmo-bts-octphy/l1_oml.c
File src/osmo-bts-octphy/l1_oml.c:
Line 1362: if (plink->u.octphy.tx_atten_flag == 1) {
particularly if (but not only if) it's a bool, the '== 1' is not needed. Just checking for if (tx_atten_flag) makes it obvious that there are no other magic values that might have other meanings, but that it's only about true/false.
Line 1364: }
no newline after else and befor eopening brace
https://gerrit.osmocom.org/#/c/905/9/src/osmo-bts-octphy/octphy_vty.c
File src/osmo-bts-octphy/octphy_vty.c:
Line 151: if (argv[0][0] == 'o') {
I think we can afford a !strcmp() here to have more clean code. it's not performance critical, after all.
--
To view, visit https://gerrit.osmocom.org/905
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bb8660eb1d8baeb6b8f69da4a6ba9ab7319981
Gerrit-PatchSet: 9
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes