[PATCH] libosmocore[master]: Constify ctrl_cmd struct fields where appropriate

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Oct 11 16:27:43 UTC 2016


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1040

to look at the new patch set (#2).

Constify ctrl_cmd struct fields where appropriate

Change-Id: I3f55c1d4b965d215dc9b16f4b284b7fea4bde9e9
---
M TODO-RELEASE
M include/osmocom/ctrl/control_cmd.h
2 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/40/1040/2

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 648b6a6..b67d6dd 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -4,3 +4,4 @@
 libosmocore	change major	size of ph_data_param struct changed / Extend L1SAP PH-DATA with presence information
 libosmocore	change major	size of ph_data_param struct changed / Extend L1SAP PH-DATA with measurement information
 libosmocore	change major	size of ph_tch_param struct changed / Extend with RTP Marker
+libosmocore	change minor	mark as const id, variable & value fields of ctrl_cmd struct
diff --git a/include/osmocom/ctrl/control_cmd.h b/include/osmocom/ctrl/control_cmd.h
index 8f2eaa2..cd96038 100644
--- a/include/osmocom/ctrl/control_cmd.h
+++ b/include/osmocom/ctrl/control_cmd.h
@@ -53,10 +53,10 @@
 struct ctrl_cmd {
 	struct ctrl_connection *ccon;
 	enum ctrl_type type;
-	char *id;
+	const char *id;
 	void *node;
-	char *variable;
-	char *value;
+	const char *variable;
+	const char *value;
 	char *reply;
 };
 

-- 
To view, visit https://gerrit.osmocom.org/1040
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f55c1d4b965d215dc9b16f4b284b7fea4bde9e9
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list