This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgHolger Freyther has submitted this change and it was merged. Change subject: build: add -Wall ...................................................................... build: add -Wall I noticed that unused variables are not complained about by the build. Let's add -Wall. I also noticed that the Makefile.ams include STD_DEFINES_AND_INCLUDES, which is never set in configure.ac, so using that to add -Wall to all build contexts. Change-Id: I16711cf5a1ef8bd611074b3dd486ed7a0ae9df64 --- M configure.ac 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 950be23..022a7f7 100644 --- a/configure.ac +++ b/configure.ac @@ -79,6 +79,9 @@ AC_MSG_RESULT([$enable_vty_tests]) AM_CONDITIONAL(ENABLE_VTY_TESTS, test "x$enable_vty_tests" = "xyes") +STD_DEFINES_AND_INCLUDES="-Wall" +AC_SUBST(STD_DEFINES_AND_INCLUDES) + AC_OUTPUT( src/Makefile examples/Makefile -- To view, visit https://gerrit.osmocom.org/982 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16711cf5a1ef8bd611074b3dd486ed7a0ae9df64 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder